Sora C++ SDK を 2024.8.0-canary.33 に上げる #44
+20
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C++ SDK が依存するその他のライブラリも合わせてアップデートする
zztkm
changed the title
zztkm
changed the title
melpon
reviewed
Dec 27, 2024
| @@ -21,16 +21,22 @@ | |||
| - @torikizi | |||
| - [CHANGE] FakeNetwork 系の機能を削除 | |||
| - @melpon | |||
| - [CHANGE] CMakeLists の依存から libva と libdrm を削除する | |||
| - @zztkm | |||
There was a problem hiding this comment.
libva と libdrm を削除しても既存のシステムは壊れないと思うので、CHANGE では無さそう
There was a problem hiding this comment.
4d59593 で UPDATE に修正しました。
CHANGES.md
Outdated
| @@ -21,16 +21,22 @@ | |||
| - @torikizi | |||
| - [CHANGE] FakeNetwork 系の機能を削除 | |||
| - @melpon | |||
| - [CHANGE] CMakeLists の依存から libva と libdrm を削除する | |||
| - @zztkm | |||
| - [CHANGE] CI の Ubuntu で libba と libdrm をインストールしないようにする | |||
There was a problem hiding this comment.
4d59593 で UPDATE に修正しました。
すべての箇所を その他 boost::optional を利用している箇所は以下がありました。
|
|
boost::optional は無くしたいのと、わざわざ別でやるほどのタスクじゃないので一緒にやっちゃって下さい |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024.8.0(2024.8.0-canary.33) に上げるm132.6834.4.0に上げる1.87.0に上げる3.30.5に上げる2.5.0に上げるabsl::nulloptをstd::nulloptに置き換えるsora_data_channel_signalingとsora_ignore_disconnect_websocketの型をstd::optional<bool>に置き換えるThis pull request includes several updates and improvements across multiple files, focusing on dependency management, version updates, and code modernization. The most important changes include removing unused dependencies, updating library versions, and replacing deprecated code constructs.
Dependency Management:
.github/workflows/build.yml: Removed the installation oflibva-devandlibdrm-devdependencies in the CI configuration.CMakeLists.txt: Removed the requirement forLibvaandLibdrmdependencies.Version Updates:
CHANGES.md: Documented the removal oflibvaandlibdrmdependencies and updated versions forlibwebrtc,Boost,CMake, andOpenH264.VERSION: Updated versions forSORA_CPP_SDK,WEBRTC_BUILD,BOOST,CMAKE, andOPENH264.Code Modernization:
src/nop_video_decoder.cpp: Replacedabsl::nulloptwithstd::nulloptin theNopVideoDecoder::Decodemethod.src/zakuro.h: Replacedboost::optionalwithstd::optionalfor certain configuration options in theZakuroConfigstruct.